Support reading service bindings from VCAP_SERVICES env var
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbusko
force-pushed
the
support-vcap-services
branch
2 times, most recently
from
db4d7cd
to
3b416f8
Compare
ForestEckhardt
approved these changes
Apr 30, 2024
Co-authored-by: Johannes Dillmann <[email protected]>
pbusko
force-pushed
the
support-vcap-services
branch
from
3b416f8
to
fb2f522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
VCAP_SERVICESenvironment variable as a source of service bindingsUse Cases
At the moment, both
libcnbandlibpak(throughlibcnb) support reading service bindings fromVCAP_SERVICESenvironment variable. This PR will bring feature-parity betweenlibpakandpackit, as well as improve user experience for the upcoming CNB@CloudFoundry RFC: cloudfoundry/community#796Checklist